Fix SQL container throughput update to preserve existing throughput buckets #9033
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Achint-Agrawal, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy and
evelyn-ys
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the CosmosDB SQL container throughput update functionality where existing throughput buckets were being unintentionally reset to None when the --throughput-buckets parameter was not explicitly provided. The fix preserves existing throughput buckets when the parameter is omitted and only removes them when explicitly set to an empty array.
Key changes:
- Added logic to preserve existing throughput buckets when the parameter is not provided
- Enhanced test coverage to verify both bucket preservation and explicit bucket removal scenarios
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
custom.py |
Added logic to retrieve and preserve existing throughput buckets when throughput_buckets parameter is None |
test_cosmosdb_sql_throughput_bucketing_scenario.py |
Added comprehensive test cases to verify bucket preservation and explicit removal behavior |
microsoft-github-policy-service
bot
added
CosmosDB
Auto-Assign
|
|
[Release] Update index.json for extension [ cosmosdb-preview-1.6.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132367107&view=results |
4 participants
Fixes a bug where updating SQL container throughput would reset existing throughput buckets to
Nonewhen the--throughput-bucketsparameter was not explicitly provided. The fix preserves existing throughput buckets when the parameter is omitted, only removing them when explicitly set to an empty array.This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az cosmosdb sql container throughput updateGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.